Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config to sync even if NVT family is not available #1347

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Nov 4, 2020

What:

When syncing a config from the feed and the NVTs do not yet exist, then sync the config anyway with "" as family.

Why:

Configs sync should succeed even if the NVTs aren't synced.

How:

DELETE FROM nvts;
Delete feed config Discovery.
Empty trash.
Discovery should auto sync.
select * from nvt_selectors where name = '74b247ae-d1fc-4105-99e2-01125889b4eb';
Should be no families.
delete from meta where name = 'nvts_feed_version' or name = 'nvts_check_time';
Wait for NVTs to sync.
select * from nvt_selectors where name = '74b247ae-d1fc-4105-99e2-01125889b4eb';
Should now have families.

Checklist:

@mattmundell mattmundell marked this pull request as ready for review November 4, 2020 21:40
@timopollmeier timopollmeier merged commit 841ca5d into master Nov 9, 2020
@mattmundell mattmundell deleted the sync-config-no-nvts branch December 7, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants