-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL errors in SCAP and CERT update (20.08) #1343
Merged
mattmundell
merged 6 commits into
greenbone:gvmd-20.08
from
timopollmeier:secinfo-update-fix-20.08
Nov 4, 2020
Merged
Fix SQL errors in SCAP and CERT update (20.08) #1343
mattmundell
merged 6 commits into
greenbone:gvmd-20.08
from
timopollmeier:secinfo-update-fix-20.08
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CVSS values are only updated if the SCAP schema exists.
To avoid errors from tables not being found, the SQL in the functions to check for new or updated SCAP and CERT data now uses schema prefixes.
mattmundell
requested changes
Nov 3, 2020
I guess this also replaces (at least parts or) #1295 ? Maybe worth to have a look at the PR. |
The variable is only used within an if block, so its scope can be reduced accordingly.
To make the behavior more consistent with the SCAP sync the debug output now also contains last_cert_update.
mattmundell
approved these changes
Nov 4, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
This fixes two SQL errors that could when updating the SCAP and CERT data:
scap.cves
table not existing.search_path
may only include the default schema, so tables likecves
are not found without a prefix (scap.
).How:
Tested by stopping gvmd, dropping the schemas
cert
andscap
, then restarting gvmd to make it rebuild both schemas.Checklist: