Fix and simplify SecInfo migration #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check must fail for both possible types not just one for the type to be invalid.
To simplify the SCAP and CERT database migration, the databases are fully reinitialized and synced again if gvmd requires a newer version.
mattmundell
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes the feed type check in
gvm_migrate_secinfoand simplifies the migration by always re-initializing and re-syncing the SCAP and CERT databases to get them to a new version.Why:
To ensure the migration works and to keep future SCAP and CERT migrations simple.
How:
Tested by modifying the value for
database_versionin the SCAP and/or CERT schema meta table to versions larger or smaller than the supported versions and runninggvmdandgvmd --migrate.Larger version numbers should be rejected while smaller ones will make gvmd rebuild the database.
Checklist: