Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inherit settings from deleted users #1328

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 14, 2020

What:
When users are deleted, the settings will be deleted instead of moved
to the inheriting user.

Why:
The inherited settings would either conflict with existing ones of the
inheriting user or could cause unexpected behavior.

How:

  • As an admin user, create a new user
  • Set the same setting both as the admin and the new user.
    (e.g. set "Rows Per Page" to "20").
  • As the admin try deleting the new users with the current admin user as the inheritor

Without the change this should fail due to a constraint violation, while it will work with it.

Checklist:

The inherited settings would either conflict with existing ones of the
inheriting user or could cause unexpected behavior.
@timopollmeier timopollmeier marked this pull request as ready for review October 14, 2020 14:58
@mattmundell mattmundell merged commit 0754740 into greenbone:gvmd-20.08 Oct 14, 2020
@timopollmeier timopollmeier deleted the deleted-user-settings branch October 15, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants