Move "feed object in trash" checks to startup #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These spam the logs because they use a static var and the sync runs in a fork now.
mattmundell
changed the title
timopollmeier
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The warnings about feed objects being in the trash are now done once, in the main process, at startup.
Why:
The warnings were spamming the logs. There was a static variable to limit the warning, but that no longer works because the sync is now done in a fork.
How:
Delete a feed config, report format and port list. Keep them in the trashcan.
Startup gvmd.
In the logs there should be one and only one warning for each of the three types.
Checklist: