Skip DB check in helpers when main process is running #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DB check runs create_tables. Helper processes (--get-users etc) can safely skip the check when the main process is running, because the main process has done the check. This avoids deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Skip DB check in helpers (--create-user, etc) when main process is running.
Why:
The create_tables in the db check was causing deadlock.
How:
1
tail -f gvmd.log | grep -i "deadlock detected"2
while true; do gvmd --modify-setting 78eceaec-3385-11ea-b237-28d24461215b --value d1ab52ec-a88a-4ef3-99d5-57123f88a95c; done3 In GSA refresh the results page.
4 Without patch should see tail output after 1 or 2 refreshes.
Checklist: