Copy instead of moving when migrating predefined report formats #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better, because the existing directories may not be writable by gvmd.
timopollmeier
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When migrating predefined report formats copy the old directory instead of moving it.
Why:
When a report format is migrated from the old predefined report format location (share/gvm/gvmd) gvmd may not have write access to the existing directory.
How:
1 Make sure old dir exists
2 Make the old parent dir read-only. eg /home/matt/alts/gvm208/share/gvm/gvmd/report_formats/
3 Remove owner from the report format (using SQL).
4 Set Feed Import Owner with --modify-setting (the will trigger the migrate).
Checklist: