Check feed status without acquiring lock #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acquiring the file lock when checking if the feeds are current can make it appear as if an update is in progress, so the checks are first performed before attempting to acquire the lock.
This makes it simpler to get the feed version from the scanner without comparing it to the database version.
This way the main process is not blocked if part of the version check like getting the VTs feed version from the scanner takes longer to complete.
The feed type must be either "cert" or "scap" and the database check must use the correct type.
mattmundell
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feed versions / timestamps are now checked without acquiring the lock on the lockfile first so the check does not appear as an update in progress.
This check and handling the actual updates is also done in a forked process now so the scanner taking longer to respond with the feed version does not block the main process.
Checklist: