Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing min_qod to FILTERS in GET_VULNS response #1224

Merged
merged 7 commits into from
Aug 11, 2020
Merged

Add missing min_qod to FILTERS in GET_VULNS response #1224

merged 7 commits into from
Aug 11, 2020

Conversation

mattmundell
Copy link
Contributor

Checklist:

@mattmundell mattmundell changed the title Get vulns min qod Add missing min_qod to FILTERS in GET_VULNS response Aug 5, 2020
@mattmundell mattmundell marked this pull request as ready for review August 5, 2020 13:48
timopollmeier
timopollmeier requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the vulns should get a separate case where only min_qod is added to the filter because apply_overrides has no effect.

@mattmundell
Copy link
Contributor Author

I think the vulns should get a separate case where only min_qod is added to the filter because apply_overrides has no effect.

Done in 6a1ad11.

timopollmeier
timopollmeier previously approved these changes Aug 11, 2020
View reviewed changes
@bjoernricks bjoernricks merged commit a797e5e into greenbone:gvmd-20.08 Aug 11, 2020
@mattmundell mattmundell deleted the get-vulns-min-qod branch August 26, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmundell @timopollmeier @bjoernricks