-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove classic schedule elements from GMP #1116
Remove classic schedule elements from GMP #1116
Conversation
It's not used by GSA, and is not so useful because it is the abbrev for the first time, but the abbrev can change due to DST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with removing most of the old elements but I wonder if we should keep the info when the schedule is next run in get_schedules
just because that information cannot simply be extracted from the iCalendar but also requires some time calculations that can get pretty complex depending on the recurrence rules used.
Thanks, I"m going to merge because we don't help the GMP user build the ical, so I think it's OK that we don't help them decipher the ical. GSA is already doing these calculations. If it's a problem we can add it back later. |
Checklist: