Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classic schedule elements from GMP #1116

Merged
merged 17 commits into from
Jun 8, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jun 3, 2020

Checklist:

@mattmundell mattmundell changed the title Remove support for classic schedules from GMP Remove classic schedules elements from GMP Jun 3, 2020
@mattmundell mattmundell changed the title Remove classic schedules elements from GMP Remove classic schedule elements from GMP Jun 3, 2020
@mattmundell mattmundell marked this pull request as ready for review June 3, 2020 18:40
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with removing most of the old elements but I wonder if we should keep the info when the schedule is next run in get_schedules just because that information cannot simply be extracted from the iCalendar but also requires some time calculations that can get pretty complex depending on the recurrence rules used.

@mattmundell
Copy link
Contributor Author

I'm okay with removing most of the old elements but I wonder if we should keep the info when the schedule is next run in get_schedules just because that information cannot simply be extracted from the iCalendar but also requires some time calculations that can get pretty complex depending on the recurrence rules used.

Thanks, I"m going to merge because we don't help the GMP user build the ical, so I think it's OK that we don't help them decipher the ical. GSA is already doing these calculations. If it's a problem we can add it back later.

@mattmundell mattmundell merged commit fc97bfe into greenbone:master Jun 8, 2020
@mattmundell mattmundell deleted the reduce-schedule-gmp branch June 8, 2020 11:31
@mattmundell mattmundell mentioned this pull request Jun 16, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants