Stop current scheduling of task when permission denied #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the schedular from failing to start the task every 10 seconds forever, when the user does not have permission to run the task. This can happen, for example, if the task uses someone else's target, and permission to access the target is revoked.
mattmundell
changed the title
timopollmeier
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the scheduler from failing to start the task every 10 seconds
forever, when the user does not have permission to run the task. This can
happen, for example, if the task uses someone else's target, and permission
to access the target is revoked.
Note that this only affects the current attempt to run the task. If the schedule
is periodic then the scheduler will try again next time the task is due.
Requires greenbone/gvm-libs#327.
Checklist: