Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct element to get task ID quick_task wizard #1046

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Apr 14, 2020

Checklist:

@mattmundell mattmundell marked this pull request as ready for review April 14, 2020 16:56
@mattmundell
Copy link
Contributor Author

Very similar to #1004.

@bjoernricks
Copy link
Contributor

Did we change the xml in master or why does this only occur now?

@mattmundell
Copy link
Contributor Author

mattmundell commented Apr 15, 2020

Did we change the xml in master or why does this only occur now?

Actually the error is present in GVM 11 too:

md   main:  DEBUG:2020-04-15 10h39.48 UTC:25549: -> client: <run_wizard_response status="202" status_text="Failed to start task: OK, request submitted"><response><commands_response status="200" status_text="OK"><get_tasks_response status="404" status_text="Failed to find task ''"/></commands_response></response></run_wizard_response>

Something must have changed in GSA to properly recognise the error. EDIT: Or it show up now in GSA because we removed the wrapping COMMANDS.

Either way the wizard still functions because the step that is failing is just the final, cleanup step.

@mattmundell mattmundell merged commit 0f3eb28 into greenbone:master Apr 15, 2020
@mattmundell mattmundell deleted the wizard-errors branch April 15, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants