Do not skip scan_config if preference was not found #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
requested changes
Mar 18, 2020
There was a problem hiding this comment.
I'm worried that we will have incomplete configs if we allow the configs to be synced when the preference does not exist. This could occur when the config sync happens before the NVTs are fully synced. Safer to wait for the preference to be available, I think.
mattmundell
requested review from
mattmundell
and removed request for
mattmundell and
timopollmeier
mattmundell
previously approved these changes
Jul 29, 2020
This ensures that the config preference is created even when the NVT or NVT preference has not arrived in the feed yet. It is required because syncing of configs no longer requires the NVT preferences to all be present (in order to speed up availability of feed defined configs during initial sync).
timopollmeier
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config preferences are always included when syncing configs with the feed, even if they do not exist in the NVT preferences.
For consistency the same behaviour is applied when uploading configs.
The motivation is that feed defined configs should be available as soon as possible, even if the associated NVT info has not been synced yet.
Checklist: