Add: Allow getting score of CVSS 4.0 vectors #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function get_cvss_score_from_base_metrics can now also calculate the score of CVSS 4.0 vectors.
These should never occur but this ensures the values are always set, so variables are initialized.
timopollmeier
force-pushed
the
add-cvss4
branch
from
6e0f27a
to
1bdb8a5
Compare
The max_vectors should never be empty, so an invalid value is assigned just for safety.
a-h-abdelsalam
requested changes
May 10, 2024
A typo has been fixed and some missing frees, error handling cases and comments have been added.
|
There is a code format error that is causing the build CI check to fail. You may need to run: |
a-h-abdelsalam
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The function get_cvss_score_from_base_metrics can now also calculate the score of CVSS 4.0 vectors.
Why
To be able to use CVSS 4.0 in VTs.
References
GEA-529
Checklist