Initialize reallocated memory in gvm_hosts_add #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the array memory for the hosts is reallocated, the new memory is initialized with all \0 bytes. This ensures the array is correctly terminated when gvm_hosts_fill_gaps is called when excluding hosts.
timopollmeier
added
backport-to-oldstable
y0urself
reviewed
Jun 17, 2021
y0urself
requested changes
Jun 17, 2021
Co-authored-by: Jaspar L. <[email protected]>
The offset must not be multiplied with the pointer size as it is already implied by the pointer arithmetic.
y0urself
approved these changes
Jun 18, 2021
timopollmeier
added a commit
to timopollmeier/gvm-libs
that referenced
this pull request
Jun 18, 2021
If the array memory for the hosts is reallocated, the new memory is initialized with all \0 bytes. This ensures the array is correctly terminated when gvm_hosts_fill_gaps is called when excluding hosts. This is a backport of greenbone#520.
2 tasks
timopollmeier
added a commit
to timopollmeier/gvm-libs
that referenced
this pull request
Jun 18, 2021
If the array memory for the hosts is reallocated, the new memory is initialized with all \0 bytes. This ensures the array is correctly terminated when gvm_hosts_fill_gaps is called when excluding hosts. This is a backport of greenbone#520.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If the array memory for the hosts is reallocated, the new memory is
initialized with all \0 bytes.
Why:
This ensures the array is correctly terminated when gvm_hosts_fill_gaps
is called when excluding hosts.
How:
By creating multiple targets with very large host ranges (> 2 million hosts) and adding excluded hosts to at least one of them.
Checklist: