Use double for scores in vtseverity_t and helpers #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typedef and the functions nvti_severity_score, vtseverity_new and vtseverity_new now use double to be able to handle CVSS scores.
2 tasks
timopollmeier
added
the
backport-to-main
bjoernricks
approved these changes
Apr 9, 2021
nichtsfrei
added a commit
that referenced
this pull request
Apr 13, 2021
Use double for scores in vtseverity_t and helpers (bp #472)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The typedef and the functions nvti_severity_score, vtseverity_new and
vtseverity_new now use double to be able to handle CVSS scores.
Why:
The score handling in gvmd will use CVSS scores instead of integer ones.
How:
Tested by running gvmd --rebuild in an updated gvmd that uses CVSS scores and checking that scores are not truncated to integers.
Checklist: