Fix finish_signal_on_queue #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the signal in the whole items under the key, instead of just checking the the last item.
jjnicola
force-pushed
the
realloc-boreas-fin
branch
from
2f2b20e
to
8b8f088
Compare
jjnicola
added
the
backport-to-main
Co-authored-by: ArnoStiefvater <[email protected]>
ArnoStiefvater
approved these changes
Mar 22, 2021
ArnoStiefvater
added a commit
that referenced
this pull request
Mar 22, 2021
Fix finish_signal_on_queue (bp #464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix finish_signal_on_queue. Check for the signal in the whole items under the key, instead of
just checking the the last item.
Why:
In some cases the
finishedwas not reallocated causing interrupted scansHow:
Run a scan with Boreas alive test, with
expand_vhostsoption enabled andallow_simultaneous_ipsdisabled. Check that the scan is not interrupted and all hosts are scanned.Checklist: