Reduce timout for alive tests #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the ping timeout was 5 seconds. Now the timeout is set to 1 second. We already have some wait of 0.5 secs in the pinging function. So in total we wait 1.5 seconds for replies now. This should be enough for most use cases.
If already all hosts in the target list were identified as alive we do not need to wait for ping replies anymore.
ArnoStiefvater
force-pushed
the
reduce-wait
branch
from
608a4f4
to
f20c13e
Compare
ArnoStiefvater
requested review from
jjnicola and
mattmundell
as code owners
jjnicola
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Reduces time of alive test if target list is small.
Why:
To reduce the time of tests.
How:
Read the logs when doing a scan of 1 host. Previously scan took about 9 second, now it takes about 5 seconds.
Checklist: