Chart improvements #989
Chart improvements #989
Commits on Oct 2, 2018
-
No need to put hasSvg into the DataDisplay state
hasSvg can always be derived in render.
-
Allow to toggle the Legend in children of DataDisplay
Add icon to toggle displaying the legend of charts.
-
Use DataDisplay icons prop as render props
Allow to override the icon prop of DataDisplay to render different icons for a chart.
-
Add a chartState to DataDisplay
Allow to set and get state for charts in DataDisplay. Setting the state will also re-render the children which wouldn't be possible if a chart keeps the state internally in it's component. At a first step the showLegend state is put into the chart state. In future this chart state will be saved in the redux store too.
-
Move MENU_PLACEHOLDER_WIDTH to a new js module
Chart modules should not depend on dashboard components. Charts components are only for displaying some data and dashboards for orchestrating different displays which might be charts.
-
Add a default shouldUpdate implementation for charts
Charts must be updates at least if data, width or height props have changed.
-
-
-
Use showLegend prop to toggle displaying chart Legends
Rename displayLegend of Bar chart to showLegend and add showLegend to Donut chart.
-
Fix calculating the Bar chart width with Legend displayed
If the legend is displayed the Bar chart must be rendered again after the ref is set. Also update chart to use new React.createRef API.
-
-
Move LineChart proptypes to the bottom
We have mostly all proptypes at the bottom of the js module. Therefore it's demanding to search for the LineChart proptypes.
-
Rename displayLegend into showLegend
Use showLegend prop instead of displayLegend at LineChart.
-
-
-
Avoid crashing DataDisplay on svg download
Never crash if svg or download refs aren't set. This should not ever happen but it is saver to check for this case.
-
Fix displaying the svg download icon
When the svg ref is set in a child of DataDisplay the component will not be re-rendered necessarily. Therefore the svg ref may be set but the icon is still not displayed. Therefore add an external prop to deactivate the svg download icon on demand.
-
Disable svg downloads for data table displays
When displaying a table it shouldn't be possible to download a svg.
-
-
Only re-calculate state from width if the width has changed actually. Th LineChart did crash because the width has been re-calculated when hovering over the LineChart to display the tooltips. This lead to an infinite loop. Also fix calculation of the width. It uses the same pattern as the donut chart now.
-
Update shouldUpdate to consider showLegend prop
A chart should be re-rendered if the showLegend prop has changed.
-
-
Rename chart state to child state
Use initialState instead of initialChartState because the internal state variable name isn't visible outside of DataDisplay component. For children it's only the state.
