Change IconOverlay in DataDisplay #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
swaterkamp
commented
Sep 25, 2018
swaterkamp
commented
- Change appearance of overlay
- Use placeholder in some charts
- Fix x-Axis label in BarChart when FilterTerm is shown
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=========================================
- Coverage 9.12% 9.12% -0.01%
=========================================
Files 819 819
Lines 26743 26748 +5
Branches 5713 5687 -26
=========================================
Hits 2441 2441
- Misses 21961 21966 +5
Partials 2341 2341
Continue to review full report at Codecov.
|
Also change top margin to save space
Changes include: * vertical alignment * lightGray background * blend in and out on hover-on/hover-off * introducing MENU_PLACEHOLDER_WIDTH to be used in the different charts
bjoernricks
reviewed
Sep 25, 2018
| @@ -29,6 +29,9 @@ import {scaleBand, scaleLinear} from 'd3-scale'; | |||
| import {shorten} from 'gmp/utils/string'; | |||
| import {isDefined} from 'gmp/utils/identity'; | |||
|
|
|||
| import {MENU_PLACEHOLDER_WIDTH} | |||
| from 'web/components/dashboard/display/datadisplay'; | |||
|
|
|||
There was a problem hiding this comment.
Please use
import {
MENU_PLACEHOLDER_WIDTH,
} from 'web/components/dashboard/display/datadisplay';instead or put it into one line and add // eslint-disable-line max-len
bjoernricks
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.