Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard display menues #971

Merged
merged 5 commits into from
Sep 25, 2018
Merged

Remove dashboard display menues #971

merged 5 commits into from
Sep 25, 2018

Conversation

bjoernricks
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #971 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #971      +/-   ##
=========================================
+ Coverage    9.09%    9.1%   +0.01%     
=========================================
  Files         820     819       -1     
  Lines       26774   26743      -31     
  Branches     5718    5686      -32     
=========================================
  Hits         2436    2436              
+ Misses      21992   21964      -28     
+ Partials     2346    2343       -3
Impacted Files Coverage Δ
...sa/src/web/components/dashboard/display/display.js 0% <ø> (ø) ⬆️
...omponents/dashboard/display/withFilterSelection.js 0% <ø> (ø) ⬆️
...rc/web/components/dashboard/display/datadisplay.js 0% <0%> (ø) ⬆️
...eb/components/dashboard/display/filterselection.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c622d1...e1232d8. Read the comment docs.

flex-grow: 1;
position: relative;

& .display-icon-bar {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In styled-components you can directly reference components without the detour with classnames.
So what you can do here, is something like that:
'''
${IconBar}: {
visibility: hidden;
opacity: 0;
}

Extends FilterSelection and withFilterSelection to pass handler to open
the filter selection dialog down to the children function/component.
The icon overlay is shown if a user hovers over a dashboard display.
The api for loadEntities has changed.
The component is obsolete now.
@swaterkamp swaterkamp merged commit 4c74f8f into greenbone:master Sep 25, 2018
@bjoernricks bjoernricks deleted the remove-dashboard-display-menues branch September 25, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants