Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist locales #966

Merged
merged 6 commits into from
Sep 21, 2018
Merged

Whitelist locales #966

merged 6 commits into from
Sep 21, 2018

Conversation

bjoernricks
Copy link
Contributor

No description provided.

The list will be used in the gmp part too. Also use correct seperators
for specific language codes like zh-CN and pt-BR.
Log the error only as a warning because the language will be set
regardless of whether an error occurred.
Don't set a locale that isn't supported.
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #966 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #966      +/-   ##
=========================================
+ Coverage    9.07%    9.1%   +0.02%     
=========================================
  Files         819     820       +1     
  Lines       26768   26776       +8     
  Branches     5715    5692      -23     
=========================================
+ Hits         2429    2437       +8     
+ Misses      21994   21993       -1     
- Partials     2345    2346       +1
Impacted Files Coverage Δ
gsa/src/gmp/gmp.js 1.49% <ø> (ø) ⬆️
gsa/src/gmp/locale/detector.js 85.29% <ø> (-0.43%) ⬇️
gsa/src/web/utils/languages.js 0% <0%> (ø) ⬆️
gsa/src/gmp/locale/languages.js 100% <100%> (ø)
gsa/src/gmp/locale/lang.js 95% <87.5%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2c521...8989b79. Read the comment docs.

@swaterkamp swaterkamp merged commit 3167cb5 into greenbone:master Sep 21, 2018
@bjoernricks bjoernricks deleted the whitelist-locales branch September 21, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants