Auto logout #908
Merged
Auto logout #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
requested review from
swaterkamp and
timopollmeier
as code owners
It's more a LocationObserver because it renews the user session if the url location has changed.
The ping command just responses an action result. It's intended to test if the user session is still valid. It doesn't extend the session. If the session is due a 401 response is returned by gsad.
The SessionObserver is responsible for issuing a ping request 15 seconds after the user session has ended to return a 401 response that will redirect to the login page. This feature is called auto logout. Technically the SessionObserver renders a Ping component that starts a timer on mount and removes the timer on unmount. SessionObserver uses a super-duper reactjs feature that changing the key on a component will always unmount and re-mount the component (see https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html#recommendation-fully-uncontrolled-component-with-a-key) for more details. This allows easy cancelling of the timer (via unmount) instead of having to synchronize user session state changes via componentWillReceiveProps, getDerivedStateFromProps and componentDidUpdate like methods.
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
=========================================
- Coverage 7.36% 7.35% -0.02%
=========================================
Files 826 827 +1
Lines 26936 26982 +46
Branches 5703 5687 -16
=========================================
Hits 1984 1984
- Misses 22544 22586 +42
- Partials 2408 2412 +4
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement auto logout feature. Using the feature needs an up to date gsad.