Load related tag resources from redux store #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
requested changes
Aug 30, 2018
| resources: PropTypes.array, | ||
| }; | ||
|
|
||
| const resoucesFilter = id => Filter.fromString( |
There was a problem hiding this comment.
There's a little typo here: resou_r_cesFilter
| entityType, | ||
| }); | ||
| return { | ||
| loadResources: () => dispatch(loadEntities(gmp)(resoucesFilter(entity.id))), |
| const {resourceType: entityType} = entity; | ||
| const selector = createSelector(entityType); | ||
| const select = selector(rootState); | ||
| const filter = resoucesFilter(entity.id); |
swaterkamp
previously approved these changes
Aug 30, 2018
Update ResourceList to load the entity resources from the redux store.
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
=========================================
- Coverage 7.48% 7.48% -0.01%
=========================================
Files 824 824
Lines 26450 26468 +18
Branches 5646 5649 +3
=========================================
Hits 1980 1980
- Misses 22099 22114 +15
- Partials 2371 2374 +3
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ResourceList to load the entity resources from the redux store.