Multi permission dialog fixes #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prop isn't interpreted by SaveDialog anymore.
Differentiate between data that is controlled from the parent component, data that is only displayed and data that is changed within the MultiPermissionDialog. The related prop is controlled from the parent component because the related entities are loaded asynchronously. id never changes but must be put into the SaveDialog state to be included in the data passed to the onSave handler. Same for the entityType. entityName is constant and is only displayed. Therefore it can be removed from the dialog state.
Name exported component EntityPermissions.
swaterkamp
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.