Fix TagDialog #871
Merged
Fix TagDialog #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=========================================
- Coverage 7.58% 7.58% -0.01%
=========================================
Files 824 824
Lines 26237 26252 +15
Branches 5864 5871 +7
=========================================
Hits 1991 1991
- Misses 21860 21875 +15
Partials 2386 2386
Continue to review full report at Codecov.
|
timopollmeier
approved these changes
Aug 17, 2018
bjoernricks
approved these changes
Aug 18, 2018
| resourceType : | ||
| first(resource_types, [])[0], | ||
| resource_types, | ||
| resources_action: |
There was a problem hiding this comment.
The variables should be changed to camelCase in another commit or PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing and changing include:
-- as a get... command yields max. 1000 elements, the resource list of tags with more than 1000 resources was cut when editing/saving. Also: manual selection of resources for tags of a certain size, does not really make sense.
-- The new concept: For tags with just a few resources (<200 atm) don't change behavior. For more than a few resources, do not show the resource selection elements and thereby don't override the original list when saving. If users want to change resources of a huge bulk tag, it is easier to delete the old tag and create a new one with adjusted resources.