Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sticky #857

Merged
merged 4 commits into from
Aug 6, 2018
Merged

Remove Sticky #857

merged 4 commits into from
Aug 6, 2018

Conversation

swaterkamp
Copy link
Member

The titlebar will no longer scroll out of view and stick the menubar to the top. Instead, our corporate green will be visible all the time. This reduces code a lot for the price of not saving 40px of space when scrolling.

@swaterkamp swaterkamp self-assigned this Aug 6, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #857 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #857      +/-   ##
=========================================
+ Coverage    7.29%   7.31%   +0.01%     
=========================================
  Files         823     821       -2     
  Lines       26062   25995      -67     
  Branches     5846    5821      -25     
=========================================
  Hits         1901    1901              
+ Misses      21780   21719      -61     
+ Partials     2381    2375       -6
Impacted Files Coverage Δ
gsa/src/web/pages/page.js 0% <ø> (ø) ⬆️
gsa/src/web/app.js 0% <0%> (ø) ⬆️
gsa/src/web/utils/globalcss.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/start/page.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39bdab...8011fea. Read the comment docs.

@bjoernricks bjoernricks merged commit 84ec32c into greenbone:master Aug 6, 2018
@swaterkamp swaterkamp deleted the RemoveSticky branch November 30, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants