Camel case api #4 #810
Merged
Camel case api #4 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop usage of Wrapper element in renderChildren and use Fragment instead.
Don't use context directly and update imports.
Both functions are only used at on single place. Therefore remove them from the render module.
Rename build_server_url into buildServerUlr and build_url_params into buildUrlParams.
Use camelCase names instead.
With this change importing from gmp/locale.js won't work anymore.
Add gmp/locale files to CMakeLists.txt file.
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
=========================================
- Coverage 6.83% 6.83% -0.01%
=========================================
Files 799 799
Lines 25869 25866 -3
Branches 5858 5860 +2
=========================================
- Hits 1769 1768 -1
Misses 21692 21692
+ Partials 2408 2406 -2
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.