Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities Loading #777

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Entities Loading #777

merged 5 commits into from
Jul 5, 2018

Conversation

bjoernricks
Copy link
Contributor

  • Add a testAll utility function
  • Put Schedule entities in the store
  • Load Schedule on demand at the TaskDetails

Leftover from copy and paste
The filters reducers must be used as filter. Also add the schedule
reducer.
Update the TaskDetails page to load the Task Schedule on demand.
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner July 5, 2018 10:31
@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #777 into master will increase coverage by 0.02%.
The diff coverage is 12.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #777      +/-   ##
=========================================
+ Coverage    6.73%   6.76%   +0.02%     
=========================================
  Files         778     779       +1     
  Lines       25972   25999      +27     
  Branches     5827    5834       +7     
=========================================
+ Hits         1750    1759       +9     
- Misses      21780   21795      +15     
- Partials     2442    2445       +3
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/details.js 0% <0%> (ø) ⬆️
gsa/src/web/store/entities/reducers.js 0% <0%> (ø) ⬆️
gsa/src/web/store/entities/schedules.js 100% <100%> (ø)
gsa/src/web/store/entities/utils/testing.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87212bb...55f7190. Read the comment docs.

@swaterkamp swaterkamp merged commit cf5bd82 into greenbone:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants