Improve tags #771
Merged
Improve tags #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
swaterkamp
commented
Jul 3, 2018
swaterkamp
commented
- Put MultiSelect into scrollable box
- Don't allow to sort tags by # of resources
The TagDialog can display many resources better, although actually using the MultiSelect does not work nicely. I think, it makes sense to use it with small numbers of resources only anyway. That means when the number of resources is too high to use the DropDown efficiently, at the same time it does not make sense anymore to change settings with it.
Also move SORT_FIELDS to where it is still used.
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=========================================
- Coverage 6.05% 6.04% -0.01%
=========================================
Files 777 777
Lines 25827 25847 +20
Branches 5814 5808 -6
=========================================
Hits 1563 1563
- Misses 21797 21817 +20
Partials 2467 2467
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.