Entities loading #753
Merged
Entities loading #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjoernricks
commented
Jun 27, 2018
•
bjoernricks
commented
- Rename load to loadAll
- Update entities store to put data in byId property
- Allow to get a single entity from the store
- Don't override byId and default with a filter
- Add automatic test creation for entities
Be more precice about the purpose of the function. It will try to load all entities.
Add a testing helper function to create a rootState for entities tests.
When loading different lists only store the ids of the loaded entities for the corresponding list and put all loaded entities in an byId indexed object. This allows to show already loaded entries (e.g. from a previous request with a different filter). Also this allows to get a single entity from the store.
Always defining the state simplifies accessing sub properties of the state.
When accessing the list of entities always return an empty array.
By using the filter string directly it would have been possible to overrride the byId and default state properties which MUST NOT be possible at all.
Add tests to ensure byId and defaults can't be overriden by an filter string in the entities state.
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=========================================
+ Coverage 5.69% 6.05% +0.36%
=========================================
Files 776 777 +1
Lines 25680 25779 +99
Branches 5793 5799 +6
=========================================
+ Hits 1462 1561 +99
Misses 21755 21755
Partials 2463 2463
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.