Extended schedules #739
Merged
Extended schedules #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ToggleButton has two states: checked and unchecked. When checked it is displayed in light green, when unchecked in light gray.
Also remove the month prop from TimeUnitSelect because the month selection will be always displayed now. Before it was deactivated for duration selection which doesn't use the TimeUnitSelect component anymore. Additionally update the selectable timeunit values to use constants from gmp/models/event.
The WeekDays class handles parsing of ical.js byday parts of recurrence rules.
The new component allows to toggle each weekday to be included in a recurrency of a schedule.
This property allows to return a WeekDays instace from a ical rrule byday part.
use freq and interval directly and add weekdays parameter for creating a rrule byday part for the ical event.
Support ical rrule frequency, interval and especially its byday part.
With this change a use can select between recurrence options Once, Hourly, Daily, Weekly, Monthly, Yearly, Workweek and Custom. Hourly till Yearly a pre-defined recurrence rules and Custom lets the user select more specific details. Currently the custom weekly repetition add an additional weekday selection. The custom monthly selection will get additional more complex options in future.
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=========================================
- Coverage 5.69% 5.63% -0.06%
=========================================
Files 768 773 +5
Lines 25335 25597 +262
Branches 5699 5795 +96
=========================================
+ Hits 1442 1443 +1
- Misses 21474 21694 +220
- Partials 2419 2460 +41
Continue to review full report at Codecov.
|
Additional allow to set the width.
* Add getSelectedWeekDay method to return the first (starts with monday) set weekday. * Add get method to return the value for a weekday
Allow to pass undefined weekdays to Event.fromData.
If no rrule bydate part is set on an ical event return undefined instead of an default unset WeekDays instance. This allows to check if byday/weekdays was set on the Event.
Add monthdays parameter to Event.fromData to allow setting the bymonthday parameter of an ical event.
If the ical event has an rrule with bymonthday part this part is returned as an array. If the part doesn't exist undefined is retuned.
When opening a ScheduleDialog load/reset the monthdays.
The component allsows to select a single weekday from the list of weekday names.
This components is like a calendar where you can toggle each day of the month to be selected.
The custom monthly recurrence has to options now: * Select the first, second, third, fourth, fifth or last weekday of a month. * Select dates/days of the month when the event should recur.
Raise an error if end date is same or before end date.
Remove extra properties weekdays and monthdays from Event class and return an object from recurrence containing these both properties. This moves all rrule related information to the recurrence.
Rename Period to Recurrence at schedule list and details pages. Not the data does show more complex recurrences beside only periods.
This allows to access translation specific data from moment. We'll use this for the ordinal (nth) translations.
The method returns an iterable array containing all weekdays and values.
Consider weekdays and monthdays for rendering a recurrence string.
Abstract all access to the weekdays data storage. Provide methods and property getters for the public api.
swaterkamp
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 5
UPDATE
Part 6
UPDATE2
Part 7
The extended schedules feature should be complete now.