Fix: Allow loading of locales like zh_TW #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
force-pushed
the
fix-language-switch
branch
from
8203090
to
6594659
Compare
Deactivate the `nonExplicitSupportedLngs` i18next setting (see https://www.i18next.com/overview/configuration-options#languages-namespaces-resources for more details) that caused our supported languages needed to contain only short codes of the languages to be a valid locale. Therefore locales like `zh_TW` were considered as not supported and the locale did fall back to `en`.
Support simple and traditional Chinese locales for our i18n message extraction tooling.
timopollmeier
force-pushed
the
fix-language-switch
branch
from
6594659
to
31d7d4b
Compare
timopollmeier
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow loading of locales like zh_TW
Why
Deactivate the
nonExplicitSupportedLngsi18next setting (see https://www.i18next.com/overview/configuration-options#languages-namespaces-resources for more details) that caused our supported languages needed to contain only short codes of the languages to be a valid locale. Therefore locales likezh_TWwere considered as not supported and the locale did fall back toen.References
#3842
#3894
GEA-294