Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Update d3 and jest-dom versions #3877

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Change: Update d3 and jest-dom versions #3877

merged 2 commits into from
Sep 27, 2023

Conversation

a-h-abdelsalam
Copy link
Contributor

What

Update the versions of d3 libraries and jest-dom.

  • import of jest-dom had to be updated since extend-expect is removed starting from jest-dom 6.0.0. See Releases
  • d3 node modules need to be transformed so that jest can parse them. See 3.0.1 doesn't work with Jest

Why

To keep the dependencies updated to the latest versions.

References

GEA-309

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner September 26, 2023 14:59
@github-actions
Copy link

Conventional Commits Report

Type Number
Changed 2

🚀 Conventional commits found.

@y0urself y0urself enabled auto-merge (squash) September 26, 2023 19:02
@y0urself y0urself merged commit 61a8c66 into main Sep 27, 2023
13 checks passed
@y0urself y0urself deleted the GEA-309-updating-dependencies branch September 27, 2023 05:49
@bjoernricks
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-h-abdelsalam @bjoernricks @y0urself