Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AP1447] Change conditions for enabling CreateTicketIcon on results detailspage #3154

Merged
merged 3 commits into from
Sep 15, 2021
Merged

[AP1447] Change conditions for enabling CreateTicketIcon on results detailspage #3154

merged 3 commits into from
Sep 15, 2021

Conversation

swaterkamp
Copy link
Member

What:
Change enabling conditions to:

  • not showing the icon when create_ticket permission is missing
  • graying out the icon if create_permission and/or get_users permissions are missing
  • enabling icon completely only if all three permissions are given

Why:
To prevent the user from misunderstandings whether they can actually create a ticket or not, because simply having create_ticket might seem sufficient, but it's not.

How:
Automated tests are still succeeding, manually testing the icon with several users with different combinations of permissions.

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Sep 15, 2021
@swaterkamp swaterkamp self-assigned this Sep 15, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner September 15, 2021 15:09
@sarahd93 sarahd93 merged commit f8a13ef into gsa-21.04 Sep 15, 2021
@sarahd93 sarahd93 deleted the swaterkamp/createTicketPerms2104 branch September 15, 2021 15:20
@mergify mergify bot mentioned this pull request Sep 15, 2021
Merged
swaterkamp added a commit that referenced this pull request Sep 16, 2021
@swaterkamp
Merge pull request #3155 from greenbone/mergify/bp/master/pr-3154
bcf8db3 
[AP1447] Change conditions for enabling CreateTicketIcon on results detailspage (backport #3154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

Assignees

@swaterkamp swaterkamp

Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaterkamp @sarahd93