Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AP1032] Show dead hosts as possible reason in empty report when scan finishes #3124

Merged
merged 2 commits into from
Aug 6, 2021
Merged

[AP1032] Show dead hosts as possible reason in empty report when scan finishes #3124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3bb7d
Change condition for showing dead host possibility in empty report
swaterkamp Aug 6, 2021
4e7dcb4
Update Changelog
swaterkamp Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Removed

### Fixed
- Show dead hosts as possible reason in empty report when scan finishes [#3124](https://github.com/greenbone/gsa/pull/3124)

[Unreleased]: https://github.com/greenbone/gsa/compare/v20.8.3...gsa-20.08

Expand Down
28 changes: 22 additions & 6 deletions gsa/src/web/pages/reports/details/emptyreport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,28 @@ const EmptyReport = ({
/>
<Divider wrap>
{!isActiveReport && (
<ReportPanel
icon={props => <TaskIcon {...props} />}
title={_('The scan did not collect any results')}
>
{_('If the scan got interrupted you can try to re-start the task.')}
</ReportPanel>
<React.Fragment>
<ReportPanel
icon={props => <TaskIcon {...props} />}
title={_('The scan did not collect any results')}
>
{_(
'If the scan got interrupted you can try to re-start the task.',
)}
</ReportPanel>
<ReportPanel
icon={props => <TargetIcon {...props} />}
title={_('The target hosts could be regarded dead')}
onClick={may_edit_target ? onTargetEditClick : undefined}
>
{_(
'You should change the Alive Test Method of the ' +
'target for the next scan. However, if the target hosts ' +
'are indeed dead, the scan duration might increase ' +
'significantly.',
)}
</ReportPanel>
</React.Fragment>
)}
{isActiveReport && progress === 1 && (
<ReportPanel
Expand Down