Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP1584][AP1608] Remove interface access of users #3123

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

swaterkamp
Copy link
Member

What:
Remove the parameters from GSA and gsad

Why:
Support is discontinued

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • [N/A] Labels for ports to other branches

@swaterkamp swaterkamp self-assigned this Aug 6, 2021
@swaterkamp swaterkamp changed the title [AP1583][AP1608] Remove interface access of users [AP1584][AP1608] Remove interface access of users Aug 6, 2021
@swaterkamp swaterkamp force-pushed the swaterkamp/removeifaces branch 3 times, most recently from 1576df5 to 270b81e Compare September 3, 2021 10:51
@swaterkamp swaterkamp force-pushed the swaterkamp/removeifaces branch from 270b81e to 4af1195 Compare September 3, 2021 10:52
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #3123 (4af1195) into master (bd8e552) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
+ Coverage   58.72%   58.73%   +0.01%     
==========================================
  Files        1041     1041              
  Lines       25142    25132      -10     
  Branches     7195     7188       -7     
==========================================
- Hits        14764    14761       -3     
+ Misses       9412     9404       -8     
- Partials      966      967       +1     
Impacted Files Coverage Δ
gsa/src/gmp/commands/users.js 33.62% <ø> (+0.29%) ⬆️
gsa/src/gmp/models/user.js 100.00% <ø> (ø)
gsa/src/web/pages/users/component.js 2.70% <ø> (ø)
gsa/src/web/pages/users/details.js 18.18% <0.00%> (+2.79%) ⬆️
gsa/src/web/pages/users/dialog.js 1.61% <ø> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8e552...4af1195. Read the comment docs.

@swaterkamp swaterkamp marked this pull request as ready for review September 3, 2021 10:53
@swaterkamp swaterkamp requested a review from a team as a code owner September 3, 2021 10:53
@swaterkamp swaterkamp merged commit 9d499e1 into master Sep 3, 2021
@swaterkamp swaterkamp deleted the swaterkamp/removeifaces branch September 3, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants