Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP1581] Don't crash target table when port_list is undefined (fix trashcan) #3120

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

swaterkamp
Copy link
Member

What:
Don't crash the target table when target.port_list is undefined.

Why:
Seems like the trashcan doesn't provide the target's portlist and therefore breaks the target table

How:
Visual check if table cell is empty (no crash) and added automatic test.

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Aug 4, 2021
@swaterkamp swaterkamp self-assigned this Aug 4, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner August 4, 2021 14:28
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #3120 (a1cb610) into gsa-21.04 (8334006) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-21.04    #3120   +/-   ##
==========================================
  Coverage      58.34%   58.34%           
==========================================
  Files           1077     1077           
  Lines          26244    26246    +2     
  Branches        7516     7518    +2     
==========================================
+ Hits           15312    15314    +2     
  Misses          9908     9908           
  Partials        1024     1024           
Impacted Files Coverage Δ
gsa/src/web/pages/targets/row.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8334006...a1cb610. Read the comment docs.

@bjoernricks bjoernricks merged commit 2c457af into gsa-21.04 Aug 5, 2021
@bjoernricks bjoernricks deleted the swaterkamp/trashcanPortLists branch August 5, 2021 06:10
swaterkamp added a commit that referenced this pull request Aug 6, 2021
[AP1581] Don't crash target table when port_list is undefined (fix trashcan) (backport #3120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants