CSP header adjustments #3068
Merged
CSP header adjustments #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
added
port-to-main
Remove frame-acestors completely because it isn't included into an iframe anymore. If this is still required the CSP settings can be adjusted via a command line parameter. More important don't allow executing javascript from inline html. Only from references javascript files. But allow to load CSS from inline <style> elements via style-src-elem (not supported by firefox yet) and style-src CSP settings. Fixes AP-1507
bjoernricks
force-pushed
the
bricks/csp-header-adjustments
branch
from
5718ae7
to
69b5f21
Compare
Froma https://create-react-app.dev/docs/advanced-configuration > By default, Create React App will embed the runtime script into > index.html during the production build. When set to false, the script > will not be embedded and will be imported as usual. This is normally > required when dealing with CSP.
bjoernricks
force-pushed
the
bricks/csp-header-adjustments
branch
from
69b5f21
to
a6a9cea
Compare
sarahd93
approved these changes
Jul 21, 2021
This was referenced Jul 21, 2021
bjoernricks
added a commit
that referenced
this pull request
Jul 21, 2021
CSP header adjustments (backport #3068)
bjoernricks
added a commit
that referenced
this pull request
Jul 21, 2021
CSP header adjustments (backport #3068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove frame-acestors completely because it isn't included into an
iframe anymore. If this is still required the CSP settings can be
adjusted via a command line parameter.
More important don't allow executing javascript from inline html. Only
from references javascript files.
But allow to load CSS from inline <style> elements via style-src-elem
(not supported by firefox yet) and style-src CSP settings.
Fixes AP-1507
Checklist: