Use UNSET_VALUE as default for relation of severity values in powerfilter #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #3052 +/- ##
==========================================
Coverage 53.74% 53.74%
==========================================
Files 1073 1073
Lines 25912 25912
Branches 7375 7375
==========================================
Hits 13926 13926
Misses 10882 10882
Partials 1104 1104
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Jul 2, 2021
y0urself
added a commit
that referenced
this pull request
Jul 3, 2021
Use UNSET_VALUE as default for relation of severity values in powerfilter (backport #3052)
y0urself
added a commit
that referenced
this pull request
Jul 3, 2021
Use UNSET_VALUE as default for relation of severity values in powerfilter (backport #3052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use UNSET_VALUE as default for relation of severity values in powerfilter
Why:
The Select showed "is equal to" as default value, but when updating the filter, this setting was not applied. The displayed item is set to "--" (
UNSET_VALUE) to prevent confusion.How:
Manual testing - explicitly whether/which default value is applied when not changing values in the filterdialog. Also adjusted automated tests.
Checklist: