Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize severity value with 0 in powerfilter #3031

Merged
merged 5 commits into from
Jun 25, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jun 25, 2021

What:

  • Initialize severity value in the powerfilter's SeverityValuesGroup with 0.
  • Use severity as filter keyword for result filter instead of cvss_base

Why:

  • The 0 was the default value of the NumberField, which was displayed, but was not stored in the dialog state to be
    sent with the filter update.
  • Using severity is more consistent with other entities' filters

How:
Manuel tests and new automatic test added

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added port-to-stable Use mergifiy to port PR to stable port-to-21.10 labels Jun 25, 2021
@swaterkamp swaterkamp self-assigned this Jun 25, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner June 25, 2021 10:01
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #3031 (b12f793) into gsa-20.08 (5363085) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-20.08    #3031   +/-   ##
==========================================
  Coverage      53.74%   53.74%           
==========================================
  Files           1073     1073           
  Lines          25912    25912           
  Branches        7375     7375           
==========================================
  Hits           13926    13926           
  Misses         10882    10882           
  Partials        1104     1104           
Impacted Files Coverage Δ
gsa/src/web/pages/results/filterdialog.js 37.50% <ø> (ø)
.../web/components/powerfilter/severityvaluesgroup.js 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5363085...b12f793. Read the comment docs.

@sarahd93 sarahd93 merged commit ced585d into greenbone:gsa-20.08 Jun 25, 2021
swaterkamp added a commit that referenced this pull request Jun 29, 2021
Initialize severity value with 0 in powerfilter (backport #3031)
swaterkamp added a commit that referenced this pull request Jun 29, 2021
Initialize severity value with 0 in powerfilter (backport #3031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants