Add listpage and detailspage tests #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #3024 +/- ##
=============================================
+ Coverage 54.28% 57.12% +2.84%
=============================================
Files 1076 1076
Lines 26245 26246 +1
Branches 7490 7490
=============================================
+ Hits 14246 14992 +746
+ Misses 10882 10181 -701
+ Partials 1117 1073 -44
Continue to review full report at Codecov.
|
saberlynx
force-pushed
the
backport-tests
branch
4 times, most recently
from
76d1c3c to
7a4fb3a
Compare
swaterkamp
reviewed
Jun 29, 2021
gsa/src/web/entity/__tests__/box.js
Outdated
| @@ -17,22 +17,29 @@ | |||
| */ | |||
| import React from 'react'; | |||
|
|
|||
| import Date, {setLocale} from 'gmp/models/date'; | |||
| import date, {setLocale} from 'gmp/models/date'; | |||
There was a problem hiding this comment.
This was upper case on purpose, because it's a component model, just like we have Result, Target etc in upper case as well. Putting this into lower case might give the impression, this is some kind of transformation function.
saberlynx
force-pushed
the
backport-tests
branch
from
c559f98 to
5ffef5c
Compare
swaterkamp
approved these changes
Jun 29, 2021
saberlynx
added a commit
that referenced
this pull request
Jun 29, 2021
Add listpage and detailspage tests (backport #3024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add tests from master branch and port all changes from #2660
Why:
How:
Checklist: