Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSH Elevate credential to target row #2996

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jun 15, 2021

What:

Show SSH Elevate credential on target listpage

Why:

How:

Manual and unit tests.

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #2996 (c01ee91) into gsa-21.04 (3a73f77) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c01ee91 differs from pull request most recent head 24a4783. Consider uploading reports for the commit 24a4783 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2996      +/-   ##
=============================================
+ Coverage      54.19%   54.23%   +0.03%     
=============================================
  Files           1075     1075              
  Lines          26278    26278              
  Branches        7552     7552              
=============================================
+ Hits           14241    14251      +10     
+ Misses         10921    10912       -9     
+ Partials        1116     1115       -1     
Impacted Files Coverage Δ
gsa/src/web/pages/targets/row.js 100.00% <100.00%> (+53.84%) ⬆️
gsa/src/web/entities/container.js 45.71% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a73f77...24a4783. Read the comment docs.

@saberlynx saberlynx force-pushed the elevate-listpage branch 3 times, most recently from 9cbc9e9 to 064d46e Compare June 15, 2021 09:46
@saberlynx saberlynx changed the title Add SSH Elevate credential to target row Added SSH Elevate credential to target row Jun 15, 2021
@saberlynx saberlynx marked this pull request as ready for review June 15, 2021 09:56
@saberlynx saberlynx requested a review from a team as a code owner June 15, 2021 09:56
@saberlynx saberlynx enabled auto-merge June 15, 2021 10:20
@saberlynx saberlynx merged commit 7635499 into greenbone:gsa-21.04 Jun 15, 2021
saberlynx added a commit that referenced this pull request Jun 15, 2021
Added SSH Elevate credential to target row (backport #2996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants