Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deprecation tag in NVT details #2960

Merged
merged 7 commits into from
Jun 7, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jun 4, 2021

What:
Added new isDeprecated() method to NVT model and add a note to NVT details.
deprecationTagNVTdetails

Why:
Some NVTs are marked as deprecated but that information was not visible in the GUI. Using a new method for this one specific tag seemed the most clear usage.

How:
Added automated test for method and visually check the notification in NVT details for deprecated and non-deprecated NVTs.

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added port-to-main Use mergifiy to port PR to master port-to-21.10 labels Jun 4, 2021
@swaterkamp swaterkamp self-assigned this Jun 4, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner June 4, 2021 10:39
@swaterkamp swaterkamp changed the title Deprecation tag Use deprecation tag in NVT details Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #2960 (7f93161) into gsa-21.04 (da7c00e) will decrease coverage by 0.01%.
The diff coverage is 18.51%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2960      +/-   ##
=============================================
- Coverage      53.84%   53.82%   -0.02%     
=============================================
  Files           1075     1075              
  Lines          26250    26272      +22     
  Branches        7506     7521      +15     
=============================================
+ Hits           14133    14140       +7     
- Misses         11000    11015      +15     
  Partials        1117     1117              
Impacted Files Coverage Δ
gsa/src/gmp/commands/targets.js 19.44% <0.00%> (-3.89%) ⬇️
gsa/src/gmp/models/target.js 100.00% <ø> (ø)
gsa/src/gmp/parser/cvss.js 100.00% <ø> (ø)
gsa/src/web/pages/nvts/details.js 6.66% <0.00%> (-0.23%) ⬇️
gsa/src/web/pages/results/detailspage.js 12.32% <0.00%> (ø)
gsa/src/web/pages/targets/component.js 2.45% <0.00%> (-0.07%) ⬇️
gsa/src/web/pages/targets/details.js 9.09% <0.00%> (-0.91%) ⬇️
gsa/src/web/pages/targets/dialog.js 19.23% <11.11%> (-0.22%) ⬇️
gsa/src/gmp/models/credential.js 96.66% <100.00%> (+0.05%) ⬆️
gsa/src/gmp/models/nvt.js 99.02% <100.00%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c1df5...7f93161. Read the comment docs.

@sarahd93 sarahd93 merged commit 958f6a0 into greenbone:gsa-21.04 Jun 7, 2021
swaterkamp added a commit that referenced this pull request Jun 8, 2021
Use deprecation tag in NVT details (backport #2960)
swaterkamp added a commit that referenced this pull request Jun 8, 2021
Use deprecation tag in NVT details (backport #2960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants