-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deprecation tag in NVT details #2960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2960 +/- ##
=============================================
- Coverage 53.84% 53.82% -0.02%
=============================================
Files 1075 1075
Lines 26250 26272 +22
Branches 7506 7521 +15
=============================================
+ Hits 14133 14140 +7
- Misses 11000 11015 +15
Partials 1117 1117
Continue to review full report at Codecov.
|
sarahd93
approved these changes
Jun 7, 2021
This was referenced Jun 7, 2021
swaterkamp
added a commit
that referenced
this pull request
Jun 8, 2021
Use deprecation tag in NVT details (backport #2960)
swaterkamp
added a commit
that referenced
this pull request
Jun 8, 2021
Use deprecation tag in NVT details (backport #2960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added new isDeprecated() method to NVT model and add a note to NVT details.
Why:
Some NVTs are marked as deprecated but that information was not visible in the GUI. Using a new method for this one specific tag seemed the most clear usage.
How:
Added automated test for method and visually check the notification in NVT details for deprecated and non-deprecated NVTs.
Checklist: