Allow to add ssh elevate credential to target dialog and display elevate credential in details #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberlynx
force-pushed
the
elevate-credentials-21.04
branch
from
0588966 to
f5b198a
Compare
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2954 +/- ##
=============================================
- Coverage 53.84% 53.80% -0.04%
=============================================
Files 1075 1075
Lines 26250 26269 +19
Branches 7506 7520 +14
=============================================
+ Hits 14133 14135 +2
- Misses 11000 11017 +17
Partials 1117 1117
Continue to review full report at Codecov.
|
saberlynx
force-pushed
the
elevate-credentials-21.04
branch
3 times, most recently
from
3143f57 to
cb8e54c
Compare
saberlynx
changed the title
…ential if there is no ssh_credential
saberlynx
force-pushed
the
elevate-credentials-21.04
branch
from
5c65cb3 to
aee9400
Compare
sarahd93
requested changes
Jun 4, 2021
gsa/src/web/pages/targets/dialog.js
Outdated
| @@ -107,6 +118,10 @@ const NEW_SNMP = { | |||
| types: SNMP_CREDENTIAL_TYPES, | |||
| }; | |||
|
|
|||
| const ElevatePrivilegeText = styled(Layout)` | |||
| color: ${Theme.darkRed}; | |||
There was a problem hiding this comment.
Actually, this should not be red. I talked about this with @bjoernricks and we realized that was an error in the mockup.
There was a problem hiding this comment.
Will just regular black work?
There was a problem hiding this comment.
yes just use the standard black.
bjoernricks
previously approved these changes
Jun 4, 2021
saberlynx
force-pushed
the
elevate-credentials-21.04
branch
from
ea8ce7e to
be2f581
Compare
sarahd93
approved these changes
Jun 4, 2021
saberlynx
added a commit
that referenced
this pull request
Jun 5, 2021
Allow to add ssh elevate credential to target dialog and display elevate credential in details (backport #2954)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
How:
Checklist:
Visual confirmation. Will add tests in following PR.