Fall back to cvss_base when severity subelement is missing from NVT severities #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2944 +/- ##
=============================================
+ Coverage 53.84% 53.85% +0.01%
=============================================
Files 1075 1075
Lines 26250 26250
Branches 7506 7506
=============================================
+ Hits 14133 14136 +3
+ Misses 11000 10997 -3
Partials 1117 1117
Continue to review full report at Codecov.
|
saberlynx
approved these changes
May 26, 2021
saberlynx
added a commit
that referenced
this pull request
May 28, 2021
Fall back to cvss_base when severity subelement is missing from NVT severities (backport #2944)
saberlynx
added a commit
that referenced
this pull request
May 28, 2021
Fall back to cvss_base when severity subelement is missing from NVT severities (backport #2944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fall back to cvss_base when severity subelement is missing from NVT severities
Why:
It's possible that after some migration without gvmd -rebuild the severity subelement is missing in the NVT severities. GSA broke in that case and just threw an error without proper fallback.
How:
Added a new test. Also manual check which information is shown on the detailspage for which condition.
Checklist: