Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove network source iface from tasks, audits #2942

Merged
merged 2 commits into from
May 26, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented May 25, 2021

What:

Remove remaining references to network source interface in the code. Continuation of #2902 A backport PR for master will be made with commits from both PRs.

Why:

How:

Removed irrelevant tests and manually tested.

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@saberlynx saberlynx marked this pull request as ready for review May 25, 2021 10:19
@saberlynx saberlynx requested a review from a team as a code owner May 25, 2021 10:19
@saberlynx saberlynx requested a review from bjoernricks May 25, 2021 10:19
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #2942 (dd9ee5e) into gsa-21.10 (3288515) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.10    #2942      +/-   ##
=============================================
+ Coverage      53.90%   53.92%   +0.01%     
=============================================
  Files           1059     1059              
  Lines          25968    25968              
  Branches        7411     7411              
=============================================
+ Hits           13999    14002       +3     
+ Misses         10859    10856       -3     
  Partials        1110     1110              
Impacted Files Coverage Δ
gsa/src/web/pages/audits/component.js 38.85% <ø> (ø)
gsa/src/web/pages/results/detailspage.js 12.32% <0.00%> (ø)
gsa/src/web/pages/scanners/component.js 2.70% <ø> (ø)
gsa/src/web/pages/tasks/component.js 30.07% <85.71%> (ø)
gsa/src/web/entities/container.js 45.71% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4394f62...dd9ee5e. Read the comment docs.

@saberlynx saberlynx changed the title Remove network source iface from tasks, audits and users Completely remove network source iface from tasks, audits May 26, 2021
@saberlynx saberlynx force-pushed the remove-network-source-iface branch from d9d55ea to dd9ee5e Compare May 26, 2021 13:49
@saberlynx saberlynx enabled auto-merge May 26, 2021 14:07
@saberlynx saberlynx merged commit 9bc8744 into greenbone:gsa-21.10 May 26, 2021
@saberlynx saberlynx deleted the remove-network-source-iface branch May 27, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants