Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Pre-select greenbone sensor as default scanner type" #2924

Merged
merged 3 commits into from
May 18, 2021

Conversation

swaterkamp
Copy link
Member

What:
Make #2867 work by not presetting the type parameter for the dialog

Why:
Greenbone Sensor was still not pre-selected

How:
manual test

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp added port-to-main Use mergifiy to port PR to master port-to-21.10 labels May 18, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner May 18, 2021 11:08
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #2924 (a2ec2d4) into gsa-21.04 (74a1fd3) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-21.04    #2924   +/-   ##
==========================================
  Coverage      53.83%   53.84%           
==========================================
  Files           1075     1075           
  Lines          26226    26250   +24     
  Branches        7491     7506   +15     
==========================================
+ Hits           14118    14133   +15     
- Misses         10993    11000    +7     
- Partials        1115     1117    +2     
Impacted Files Coverage Δ
gsa/src/web/pages/notes/dialog.js 4.87% <ø> (ø)
gsa/src/web/pages/nvts/solution.js 22.22% <0.00%> (-11.12%) ⬇️
gsa/src/web/pages/radius/dialog.js 66.66% <ø> (ø)
gsa/src/web/pages/results/dashboard/index.js 75.00% <ø> (ø)
gsa/src/web/pages/results/details.js 6.74% <0.00%> (-0.16%) ⬇️
gsa/src/web/pages/scanners/component.js 2.70% <ø> (ø)
gsa/src/web/pages/schedules/dialog.js 10.23% <ø> (ø)
gsa/src/web/pages/targets/details.js 10.00% <ø> (ø)
gsa/src/web/pages/usersettings/dialog.js 29.41% <ø> (ø)
gsa/src/web/pages/scanners/dialog.js 70.31% <66.66%> (+0.47%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e2af8...a2ec2d4. Read the comment docs.

@bjoernricks bjoernricks merged commit fa7aae3 into greenbone:gsa-21.04 May 18, 2021
swaterkamp added a commit that referenced this pull request May 18, 2021
Fix "Pre-select greenbone sensor as default scanner type" (backport #2924)
sarahd93 added a commit that referenced this pull request May 18, 2021
Fix "Pre-select greenbone sensor as default scanner type" (backport from #2924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants