Fix unable to edit schedules with number only name #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2914 +/- ##
==========================================
Coverage 53.83% 53.84%
==========================================
Files 1075 1075
Lines 26226 26250 +24
Branches 7491 7506 +15
==========================================
+ Hits 14118 14133 +15
- Misses 10993 11000 +7
- Partials 1115 1117 +2
Continue to review full report at Codecov.
|
swaterkamp
requested changes
May 17, 2021
When adding a new schedule with a numbers only name `1234` and daily re occurrence and trying to edit the new schedule than a: ``` TypeError: e.replace is not a function ``` occurs because name is a number and not a string. To fix that name.toString() is called to explicitly cast it to string.
swaterkamp
previously approved these changes
May 17, 2021
bjoernricks
reviewed
May 17, 2021
Using a template literal for converting an object to string is easier to read and imho safer to do.
bjoernricks
approved these changes
May 17, 2021
This was referenced May 17, 2021
bjoernricks
added a commit
that referenced
this pull request
May 17, 2021
Fix unable to edit schedules with number only name (backport #2914)
bjoernricks
added a commit
that referenced
this pull request
May 17, 2021
Fix unable to edit schedules with number only name (backport #2914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new schedule with a numbers only name
1234and dailyre occurrence and trying to edit the new schedule than a:
occurs because name is a number and not a string.
To fix that name.toString() is called to explicitly cast it to string.
What:
Why:
How:
Checklist: