Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set result UUID in note dialog #2889

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Apr 30, 2021

What:
Set the correct value in the result uuid textfield in the notes dialog.

Why:
This allows to change the result UUID in the notes dialog. If it hasn't been set while creating a new note, the id was unchangeable, or at least not changeable to a valid UUID. It was rather taking the value of the choice whether to use a UUID or not.

How:

Checklist:

  • [N/A] Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@swaterkamp swaterkamp self-assigned this Apr 30, 2021
@swaterkamp swaterkamp requested a review from a team as a code owner April 30, 2021 09:25
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #2889 (79a083c) into gsa-21.04 (74a1fd3) will increase coverage by 0.01%.
The diff coverage is 77.08%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2889      +/-   ##
=============================================
+ Coverage      53.83%   53.84%   +0.01%     
=============================================
  Files           1075     1075              
  Lines          26226    26245      +19     
  Branches        7491     7503      +12     
=============================================
+ Hits           14118    14132      +14     
- Misses         10993    10996       +3     
- Partials        1115     1117       +2     
Impacted Files Coverage Δ
gsa/src/web/pages/notes/dialog.js 4.87% <ø> (ø)
gsa/src/web/pages/nvts/solution.js 22.22% <0.00%> (-11.12%) ⬇️
gsa/src/web/pages/results/dashboard/index.js 75.00% <ø> (ø)
gsa/src/web/pages/results/details.js 6.74% <0.00%> (-0.16%) ⬇️
gsa/src/web/pages/targets/details.js 10.00% <ø> (ø)
gsa/src/web/pages/usersettings/dialog.js 29.41% <ø> (ø)
gsa/src/web/pages/scanners/dialog.js 70.31% <66.66%> (+0.47%) ⬆️
gsa/src/gmp/models/certbund.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/cpe.js 94.73% <100.00%> (-0.27%) ⬇️
gsa/src/gmp/models/cve.js 98.36% <100.00%> (+0.11%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dccb0e...79a083c. Read the comment docs.

@sarahd93 sarahd93 merged commit be5d792 into greenbone:gsa-21.04 Apr 30, 2021
@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label Apr 30, 2021
swaterkamp added a commit that referenced this pull request Apr 30, 2021
Set result UUID in note dialog (backport #2889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants